Conversation
…nfig-surface audit (#93)
# Conflicts: # CHANGELOG.md
dist/ave-records-latest.json content was already current (64 records); only the manifest's generated_at timestamp needed a bump. The repo's own regenerate-records-json.yml workflow tried to do this automatically twice (runs 30374721533, 30407737766) but failed both times at the PR-creation step: GitHub Actions is not permitted to create or approve pull requests in this repo's settings. Left a stale, superseded branch (chore/regenerate-dist-records) behind each time; not used here since it also reverts the dependabot version bumps that landed via the main-develop merge.
…rial instructions (#96)
# Conflicts: # CHANGELOG.md # dist/ave-records-latest.json # dist/ave-records-latest.manifest.json
Updated image width in README for better responsiveness.
…ollaborative Shadows) (#117)
# Conflicts: # README.md # dist/ave-records-latest.manifest.json
# Conflicts: # README.md
…st_validate_data.py PR #130 added tests/test_validate_data.py with 'from scripts import validate_records'. scripts/ deliberately has no __init__.py (this repo isn't a package, see the packages = [] note in pyproject.toml). That import resolves fine under 'python -m pytest' (which inserts cwd onto sys.path), the exact command PR #130's own verification section used, but CI's actual invocation is bare 'pytest tests/ -x -q' (.github/workflows/tests.yml), which does not. Confirmed directly: PR #130's merge commit has no tests.yml check run recorded at all, only CodeQL/dependency-graph, so this was never actually verified against CI's real invocation before merging. Fix: pythonpath = ['.'] under [tool.pytest.ini_options], the standard pytest 7+ mechanism for exactly this case. Verified with the literal CI command: pytest tests/ -x -q -> 293 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs main with develop: one real change, a CI-invocation fix.
PR #130 added tests/test_validate_data.py importing 'from scripts import validate_records'. That import resolves under 'python -m pytest' (PR #130's own verification command) but not under CI's actual invocation, bare 'pytest tests/ -x -q' (.github/workflows/tests.yml). Confirmed directly: PR #130's merge commit has no tests.yml check run recorded at all, only CodeQL/dependency-graph -- it was never actually verified against CI's real invocation before merging.
Fix: pythonpath = ['.'] under [tool.pytest.ini_options], the standard pytest 7+ mechanism for this exact case. Verified with the literal CI command: pytest tests/ -x -q -> 293 passed.